Zum Inhalt der Seite gehen
I think I've finally found the missing puzzle piece: the nextcloud music app does subsonic and it's way more complete than @funkwhale 's implementation, so it actually works well with most of the subsonic sources in things like Music Assistant.
@Funkwhale
Funkwhale
out of curiosity, what is missing in our subsonic implementation ?
Martin Giger
Indexing didn't work reliably - sadly I don't know why that failed. When browsing I'd get errors for /rest/getTopSongs.view on the artist page. The other error I'd see is /rest/getAlbumInfo2.view
Funkwhale
i'm not sure why you're saying indexing is reliable.

But indeed don't implemented `getTopSongs` and `getAlbumInfo2` endpoints. Opening an issue to make this happen in v2 :)
Martin Giger
musicassistant indexes whats available in its own database from what I can tell. It would get all the artists from my funkwhale instance but lots of albums and tracks were missing.
Martin Giger
it seems their whole adapter for subsonic is contained in https://github.com/music-assistant/server/blob/d26eb40092bad8f680ddbf9ab4997d0dd816b3dd/music_assistant/providers/opensubsonic/sonic_provider.py - so maybe indexing was unreliable because of the getalbuminfo2 issue?

server/music_assistant/providers/opensubsonic/sonic_provider.py at d26eb40092bad8f680ddbf9ab4997d0dd816b3dd · music-assistant/server

Music Assistant is a free, opensource Media library manager that connects to your streaming services and a wide range of connected speakers. The server is the beating heart, the core of Music Assis...
GitHub
Funkwhale
probably, `get_album` will raise an exception while quering funkwhale and it's use a lot in the code you provided.
Funkwhale
well this relies on last.fm data. I don't want to spend my time on this but feel free to add support.
Could be nice if the #subsonic api allowed to choose the service. Maybe we could use our own data provider and not follow their spec. I'm not sure about this.
#subsonic
Funkwhale
well actually i don't understand what should be getAlbumInfo2 response. The doc is not clear https://opensubsonic.netlify.app/docs/endpoints/getalbuminfo2/

if you have any implementation or response example let us know by publishing it there : https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2392

subsonic getAlbumInfo2 and getTopSongs endpoint (#2392) · Issues · funkwhale / funkwhale · GitLab

add these to endpoints : https://opensubsonic.netlify.app/docs/endpoints/getalbuminfo2/ how is it used ? oO
GitLab
⇧